Re: Header checking failures on LLVM-less machines
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-01-29T03:19:32Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > I don't think we are actually contradicting each other. The aim of that > error was to prevent pieces of code that aren't conditional on > --with-llvm from including llvmjit.h. I was, for a moment and wrongly, > thinking that we could style the header in a way that'd make it both for > safe for cpluspluscheck and still error in that case, but that was a > brainfart. But even leaving that brainfart aside, I'm not arguing > against adding those include guards, so ...? Works for me now. Thanks for fixing. regards, tom lane
Commits
-
Fix LLVM related headers to compile standalone (to fix cpluspluscheck).
- 6a5c0bb6abbf 11.2 landed
- da05eb51debd 12.0 landed