Re: Removing unneeded self joins

Andrei Lepikhov <a.lepikhov@postgrespro.ru>

From: "Andrey V. Lepikhov" <a.lepikhov@postgrespro.ru>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: Heikki Linnakangas <hlinnaka@iki.fi>, David Rowley <dgrowleyml@gmail.com>, David Steele <david@pgmasters.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-01-11T04:07:15Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove GUC_NOT_IN_SAMPLE from enable_self_join_elimination
- 717d0e8dd945 18.0 landed
Put enable_self_join_elimination into postgresql.conf.sample
- c2d329260cd8 18.0 landed
Get rid of ojrelid local variable in remove_rel_from_query()
- e167191dc146 18.0 landed
Implement Self-Join Elimination
- fc069a3a6319 18.0 cited
Revert: Remove useless self-joins
- d1d286d83c0e 17.0 landed
Replace lateral references to removed rels in subqueries
- 466979ef031a 17.0 landed
Replace relids in lateral subquery parse tree during SJE
- 489072ab7a9e 17.0 landed
Forbid SJE with result relation
- 8c441c082797 17.0 landed
Fix misuse of RelOptInfo.unique_for_rels cache by SJE
- 30b4955a4668 17.0 landed
Replace the relid in some missing fields during SJE
- a7928a57b9f0 17.0 landed
Revert 56-bit relfilenode change and follow-up commits.
- a448e49bcbe4 16.0 cited
Stabilize timetz test across DST transitions.
- 4a071afbd056 14.0 cited
Speed up finding EquivalenceClasses for a given set of rels
- 3373c7155350 13.0 cited
Fix mark-and-restore-skipping test case to not be a self-join.
- 24d08f3c0a1f 12.0 landed

Attachments

v25_1-0001-Remove-self-joins.patch (text/x-patch)

On 1/7/21 7:08 PM, Masahiko Sawada wrote:
> On Mon, Nov 30, 2020 at 2:51 PM Andrey V. Lepikhov
> <a.lepikhov@postgrespro.ru> wrote:
>> Thanks, it is my fault. I tried to extend this patch with foreign key
>> references and made a mistake.
>> Currently I rollback this new option (see patch in attachment), but will
>> be working for a while to simplify this patch.
> 
> Are you working to simplify the patch? This patch has been "Waiting on
> Author" for 1 month and doesn't seem to pass cfbot tests. Please
> update the patch.

Yes, I'm working to improve this feature.
In attachment - fixed and rebased on ce6a71fa53.

-- 
regards,
Andrey Lepikhov
Postgres Professional