Re: Change log level for notifying hot standby is waiting non-overflowed snapshot
torikoshia <torikoshia@oss.nttdata.com>
From: torikoshia <torikoshia@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Date: 2025-03-24T14:18:07Z
Lists: pgsql-hackers
Attachments
- v2-0001-Change-log-message-when-hot-standby-is-not-access.patch (text/x-diff) patch v2-0001
On 2025-03-24 00:08, Fujii Masao wrote: >> >> Do you also think the errhint message is unnecessary? >> I agree with your idea to add a description of the overflowed >> subtransaction in the manual, but I'm not sure all users will be able >> to find it. >> Some people may not understand what needs to be done to make the >> snapshot ready for hot standby. >> I think adding an errhint may help those users. > > I see your concern that users might overlook the documentation and > struggle to find a solution. However, I still believe it's better to > include this information in the documentation rather than logging it > as a hint. Since the scenario where the hint would be useful is > relatively rare, logging it every time might be more confusing than > helpful. Thanks for your opinion and it sounds reasonable. Attached an updated patch. -- Regards, -- Atsushi Torikoshi Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.
Commits
-
Improve error message when standby does accept connections.
- b53b88109f94 18.0 landed