Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Langote <amitlangote09@gmail.com>, sbernikov@gmail.com,
PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2021-06-12T01:37:05Z
Lists: pgsql-bugs
Michael Paquier <michael@paquier.xyz> writes: > Still, the current style is not a pattern I think we should spread > around, as a lot of copy-paste gets done in new tests added and one > would easily mix up queries with pattern checks. The practice I'd > like to encourage is something like the attached, to make clear that > there is no risk to fetch incorrect logs. If you prefer. However, I'd note that this patch as it stands sort of breaks the argument I just made, as now you are interrogating the postmaster's state after sending SIGHUP and before doing anything that will wait for that to take effect. I think you should move the location-capture commands down by at least one safe_psql call. regards, tom lane
Commits
-
Improve log pattern detection in recently-added TAP tests
- fad9c8e93a65 13.4 landed
- bfd96b7a3dc2 14.0 landed
-
Fix multiple crasher bugs in partitioned-table replication logic.
- ab55d742eb71 14.0 landed
- b270713fd44b 13.4 landed