Horton

Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@lists.postgresql.org
Date: 2021-06-12T00:56:19Z
Lists: pgsql-hackers 
Bruce Momjian <bruce@momjian.us> writes:
> OK, I came up with the attached patch.  This is one of the few cases
> where the incompatibility is not clearly related to the feature, so I
> left the existing item alone and just created a new one with the same
> commit message in the incompatibilities section.

I think phrasing this as though user-defined aggregates are the only
pain point is incorrect.  For example, a custom operator based on
array_cat would have issues too.

I suggest a treatment more like

    Some built-in array-related functions changed signature (Tom Lane)

    Certain functions were redefined to take anycompatiblearray instead
    of anyarray.  While this does not affect ordinary calls, it does
    affect code that directly names these functions along with their
    argument types; for example, custom aggregates and operators based
    on these functions.  The affected functions are [ blah, blah ]


			regards, tom lane

Commits

  1. doc: add PG 14 relnote item about array function references

  2. Work around cross-version-upgrade issues created by commit 9e38c2bb5.