Re: BUG #15511: Drop table error "invalid argument"
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: ertugrul9090@gmail.com,
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
pgsql-bugs@lists.postgresql.org
Date: 2018-12-06T19:47:10Z
Lists: pgsql-bugs
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > On 2018-Nov-17, Tom Lane wrote: >> I poked at that to the extent of testing every string in 11.1's tr.po >> against our implementation of snprintf, and what I find is this: >> msgid "column %s of %s" >> msgstr "%2$s'nin %1$ sütunu" > I fixed this string in tr.po. At least it'll be correct in 11.2. Thanks! I'm also just about to push code changes for the easy parts of what I recommended earlier (have psprintf report the bogus format string, and make snprintf.c throw EINVAL for more error cases). Is anybody interested in the idea of making our own validator for the .po files? I might be willing to code it up, if I knew what its API ought to be, but I don't know the workflow in that area. regards, tom lane
Commits
-
Improve our response to invalid format strings, and detect more cases.
- d8e1de899c8e 11.2 landed
- d398119c19ef 9.6.12 landed
- d2b0b60e7193 12.0 landed
- a40ee75c1e2c 9.5.16 landed
- 6dc46f8ca83d 10.7 landed
- 3a691f8a25a8 9.4.21 landed