Re: hashing bpchar for nondeterministic collations is broken
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Richard Guo <guofenglinux@gmail.com>, pgsql-bugs@postgresql.org
Date: 2022-12-02T21:49:16Z
Lists: pgsql-bugs
Jeff Davis <pgsql@j-davis.com> writes: > But assuming someone does use that combination of features in 15.1, and > we release 15.2 with my fix in it, then the consequences could be > severe: a pg_dump with default options on their bpchar- > nondeterministic-collation-hash-partitioned table in 15.1 would be > unrestorable in 15.2. They'd need to take a new pg_dump from 15.1 with > "--load-via-partition-root" and then restore it in 15.2. Obviously that > would be bad in any case, but it's more tolerable going between servers > of different major versions. Yeah. Also, do we have this issue with hash indexes? If so reindexing might be necessary, which again would be more palatable in a major release. > So, given that this fix is unlikely to help many people in 15 and > earlier, and that there's a chance that the fix is really painful for > someone; I'm electing not to backpatch it. +1 regards, tom lane
Commits
-
Fix broken hash function hashbpcharextended().
- 7ac0f8d384a4 16.0 landed