Horton

Re: PRI?64 vs Visual Studio (2022)

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bryan Green <dbryan.green@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-12-15T19:19:01Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Test PRI* macros even when we can't test NLS translation.

  2. Avoid requiring Spanish locale to test NLS infrastructure.

  3. Drop support for MSVCRT's float formatting quirk.

  4. Drop support for MSVCRT's %I64 format strings.

  5. Use PRI?64 instead of "ll?" in format strings (continued).

  6. Use <stdint.h> and <inttypes.h> for c.h integers.

  7. Make float exponent output on Windows look the same as elsewhere.

Bryan Green <dbryan.green@gmail.com> writes:
> On 12/15/2025 12:28 PM, Tom Lane wrote:
>> ... It did work if I set lc_messages to 'C.utf8', which is a
>> known name according to this box's "locale -a", but this doesn't give
>> me a warm feeling about this approach being a lot more portable than
>> what we have.  Any ideas?

> My answer did not feel like it was right, so I checked multiple versions
> and realized there is a check.
> ...
> C.utf8 works because it is not "C" so is treated as a real locale.

Ah-hah.  I didn't think they hadn't optimized the case at all.

Experimenting here, it looks like 'C.UTF-8' might be accepted
everywhere.  I even got it to pass on Solaris's not-GNU gettext,
which I thought for sure would be the weak spot in the idea.
I'll press forward with that.

			regards, tom lane