Re: Extensions support for pg_dump, patch v27
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
Cc: Itagaki Takahiro <itagaki.takahiro@gmail.com>, PostgreSQL-Hackers <pgsql-hackers@postgresql.org>
Date: 2011-02-08T17:10:24Z
Lists: pgsql-hackers
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes: > Tom Lane <tgl@sss.pgh.pa.us> writes: >> Hm, no, that logic is the same as before no? > Well I had > if (!control->relocatable && control->schema != NULL) > And you have > + else if (control->schema != NULL) Yeah, I deleted that relocatable test because it's redundant: control->schema cannot be set for a relocatable extension, cf the test in read_extension_control_file. regards, tom lane