Re: PATCH: Update snowball stemmers

Arthur Zakirov <a.zakirov@postgrespro.ru> writes:
> On Wed, Sep 12, 2018 at 04:03:57PM -0400, Tom Lane wrote:
>> Did you miss including Makefile changes in the submitted patch?

> I've noticed the error some time ago. And I tried to understand why
> cfbot can't build it. Somehow cfbot didn't rename
> stem_ISO_8859_1_hungarian. You can see it from the commit [1]. And there
> is no new file stem_ISO_8859_2_hungarian.c [2].

Oh, patch(1) doesn't understand git's idea of "renaming" files, cf

https://www.postgresql.org/message-id/CAEepm=2+CF3PshNRAs-r8jtPLKj0K6UEACeRSqBi5Cf74L=w7Q@mail.gmail.com

I'd suggest using "git diff --no-renames", since some of us will want
to apply the patch using patch(1).

> In my laptop there is no such problem. I tried both "git apply" and
> "patch -p1". And I can build the patch.

Really?  What version of patch was that?

			regards, tom lane