Re: Failure in commit_ts tap tests
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-01-20T19:15:08Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Hmm. The test works fine for me, even if it should be obvious that the
> use of the != operator is wrong. I don't understand why it causes a
> failure only for you.
Even more interesting, the warning appears as-expected in stripped down
test cases, eg
$ perl -e 'use warnings; use Test::More; ok("Foo" ne "bar", "ok");'
ok 1 - ok
# Tests were run but no plan was declared and done_testing() was not seen.
$ perl -e 'use warnings; use Test::More; ok("Foo" != "bar", "ok");'
Argument "bar" isn't numeric in numeric ne (!=) at -e line 1.
Argument "Foo" isn't numeric in numeric ne (!=) at -e line 1.
not ok 1 - ok
# Failed test 'ok'
# at -e line 1.
# Tests were run but no plan was declared and done_testing() was not seen.
I really don't understand why this complains but the same perl version
is happy with (the previous coding in) 004_restart.pl. Perl bug?
regards, tom lane
Commits
-
Remove test for COMMENT ON DATABASE
- 7fb29ea9c626 9.5.6 landed
- 56b42a334167 9.6.2 landed
- 331f8c311b7b 10.0 landed
-
tests: Use the right Perl operator
- a600ee9e3fcc 10.0 landed