Horton

Re: pread() and pwrite()

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Jesper Pedersen <jesper.pedersen@redhat.com>, Magnus Hagander <magnus@hagander.net>, Oskari Saarenmaa <os@ohmu.fi>, Pg Hackers <pgsql-hackers@postgresql.org>, Tobias Oberstein <tobias.oberstein@gmail.com>
Date: 2018-10-09T02:49:50Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Tue, Oct 9, 2018 at 2:55 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yeah, I've been burnt by that too recently.  It occurs to me we could make
>> that at least a little less painful if we formatted the macro with one
>> line per function name:
>> 
>> AC_CHECK_FUNCS([
>> cbrt
>> clock_gettime
>> fdatasync
>> ...
>> wcstombs_l
>> ])
>> 
>> You'd still get conflicts in configure itself, of course, but that
>> doesn't require manual work to resolve -- just re-run autoconf.

> +1, was about to suggest the same!

Sold, I'll go do it.

			regards, tom lane

Commits

  1. Use pg_pread() and pg_pwrite() for data files and WAL.

  2. Provide pg_pread() and pg_pwrite() for random I/O.

  3. Convert some long lists in configure.in to one-line-per-entry style.