Horton

Re: Minimal logical decoding on standbys

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Jeff Davis <pgsql@j-davis.com>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, Amit Khandekar <amitdkhan.pg@gmail.com>, fabriziomello@gmail.com, tushar <tushar.ahuja@enterprisedb.com>, Rahila Syed <rahila.syed@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-04-07T05:02:45Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reduce the log level in 035_standby_logical_decoding.pl.

  2. 035_standby_logical_decoding: Add missing waits for replication

  3. For cascading replication, wake physical and logical walsenders separately

  4. Handle logical slot conflicts on standby

  5. Support invalidating replication slots due to horizon and wal_level

  6. Prevent use of invalidated logical slot in CreateDecodingContext()

  7. Replace replication slot's invalidated_at LSN with an enum

  8. Pass down table relation into more index relation functions

  9. Assert only valid flag bits are passed to visibilitymap_set()

  10. Remove unused _bt_delitems_delete() argument.

  11. Add xl_btree_delete optimization.

Hi,

On 4/7/23 5:47 AM, Amit Kapila wrote:
> On Thu, Apr 6, 2023 at 7:50 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>>
>> Thanks! Will update 0005.
>>
> 
> I noticed a few typos in the latest patches.
> 
> 0004
> 1.
> + * Physical walsenders don't need to be wakon up during replay unless
> 
> Typo.

Thanks! Fixed in V63 just posted up-thread.

> 
> 0005
> 2.
> +# Check if all the slots on standby are dropped. These include the 'activeslot'
> +# that was acquired by make_slot_active(), and the non-active 'inactiveslot'.
> +sub check_slots_dropped
> +{
> + my ($slot_user_handle) = @_;
> +
> + is($node_standby->slot('inactiveslot')->{'slot_type'}, '',
> 'inactiveslot on standby dropped');
> + is($node_standby->slot('activeslot')->{'slot_type'}, '', 'activeslot
> on standby dropped');
> +
> + check_pg_recvlogical_stderr($slot_user_handle, "conflict with recovery");
> +}
> +
> +# Check if all the slots on standby are dropped. These include the 'activeslot'
> +# that was acquired by make_slot_active(), and the non-active 'inactiveslot'.
> +sub change_hot_standby_feedback_and_wait_for_xmins
> +{
> + my ($hsf, $invalidated) = @_;
> +
> + $node_standby->append_conf('postgresql.conf',qq[
> + hot_standby_feedback = $hsf
> + ]);
> +
> + $node_standby->reload;
> +
> + if ($hsf && $invalidated)
> + {
> ...
> 
> The comment above change_hot_standby_feedback_and_wait_for_xmins seems
> to be wrong. It seems to be copied from the previous test.
> 

Good catch! Fixed in V63.


> 3.
> +# Verify that pg_stat_database_conflicts.confl_active_logicalslot has
> been updated
> +# we now expect 3 conflicts reported as the counter persist across reloads
> +ok( $node_standby->poll_query_until(
> + 'postgres',
> + "select (confl_active_logicalslot = 4) from
> pg_stat_database_conflicts where datname = 'testdb'", 't'),
> + 'confl_active_logicalslot updated') or die "Timed out waiting
> confl_active_logicalslot to be updated";
> 
> The comment incorrectly mentions 3 conflicts whereas the query expects 4.
> 

Good catch, fixed in v63.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com