Re: [PATCH] hs_standby_disallowed test fix

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Michail Nikolaev <michail.nikolaev@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2020-05-12T03:05:22Z
Lists: pgsql-hackers

On 2020/05/12 8:03, Michail Nikolaev wrote:
> Hello.
> 
> There is a recent commit about changes in way read-only commands are
> prevented to be executed [1].
> 
> It seems like hs_standby_disallowed test is broken now.
> 
> So, a simple patch to fix the test is attached.

Thanks for the report and patch! LGTM.

I just wonder why standbycheck regression test doesn't run by default
in buildfarm. Which caused us not to notice this issue long time. Maybe
because it's difficult to set up hot-standby environment in the
regression test? If so, we might need to merge standbycheck test into
TAP tests for recovery.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



Commits

  1. Correct standbycheck regression test output.