Horton

Re: Add "format" target to make and ninja to run pgindent and pgperltidy

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Jelte Fennema-Nio <postgres@jeltef.nl>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>
Date: 2025-12-31T16:13:44Z
Lists: pgsql-hackers 
On 2025-12-31 We 10:54 AM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net> writes:
>> On 2025-12-31 We 10:26 AM, Tom Lane wrote:
>>> On the substance of the patch: I wonder whether we could make things
>>> more reliable by using git metadata to figure out which .h and .c
>>> files to point pgindent at.
>> I guess what you're wanting is a test to see if the file is in git or a
>> generated file? That doesn't really arise for me as I always do vpath
>> builds, so generated files are always elsewhere.
> Right.  But if we're trying to make this easy, we need to make
> the automation work for all three use-cases (in-tree makefiles,
> vpath makefiles, meson).  I was just wondering if relying on
> git would simplify getting the same results in all three.
>
> 			



I think we could use

     git ls-files -t $file

or similar.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com