Re: Remove SpinLockFree() / S_LOCK_FREE()?
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Date: 2020-06-08T23:00:26Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > We currently have > * bool SpinLockFree(slock_t *lock) > * Tests if the lock is free. Returns true if free, false if locked. > * This does *not* change the state of the lock. > [ which isn't used ] > Thus: Let's just remove SpinLockFree() / S_LOCK_FREE()? Yeah. I think they were included in the original design on the theory that we'd need 'em someday. But if we haven't found a use yet we probably never will. So +1 for narrowing the API a tad. (We'd lose some error checking ability in the S_LOCK_TEST code, but probably that's not worth worrying about.) regards, tom lane
Commits
-
Remove SpinLockFree() and S_LOCK_FREE().
- ba401828c194 19 (unreleased) landed