Horton

Re: pg_stat_statements vs. SELECT FOR UPDATE

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-01-19T17:00:30Z
Lists: pgsql-hackers 
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> I propose that it should not ignore rowMarks, per the attached patch or
> something similar.

+1 for not ignoring rowMarks, but this patch seems like a hack to me.
Why didn't you just add RowMarkClause as one of the known alternative
expression node types?  There's no advantage to hard-wiring such
restrictive assumptions about where it can appear.

			regards, tom lane

Commits

  1. Teach pg_stat_statements not to ignore FOR UPDATE clauses