Re: Patch: Remove gcc dependency in definition of inline functions
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Mansion <james@mansionfamily.plus.com>
Cc: Marko Kreen <markokr@gmail.com>, Bruce Momjian <bruce@momjian.us>, Peter Eisentraut <peter_e@gmx.net>, Kurt Harriman <harriman@acm.org>, pgsql-hackers@postgresql.org
Date: 2009-12-02T19:51:45Z
Lists: pgsql-hackers
James Mansion <james@mansionfamily.plus.com> writes: > Marko Kreen wrote: >> Note - my proposal would be to get rid of HAVE_INLINE, which >> means we are already using inline functions unconditionally >> on platforms that matter (gcc). Keeping duplicate code >> for obsolete compilers is pointless. > Microsoft C doesn't matter? Breaking compilers that don't have inline at all isn't happening; it wouldn't buy us anything much anyway. The debate here is about how much we can assume about the behavior of compilers that do recognize the keyword. In particular, do they behave sensibly when finding an unreferenced static inline function, which is what would occur in many modules if we allow them to see inline functions in headers. regards, tom lane