Re: Cleanup some -I$(libpq_srcdir) in makefiles
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
Robert Haas <robertmhaas@gmail.com>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-12-29T22:06:20Z
Lists: pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes: > On Wed, 23 Dec 2020 at 18:07, Michael Paquier <michael@paquier.xyz> wrote: >> adminpack and old_snapshot have no need for those references as they >> don't use libpq. Any objections to a small-ish cleanup that removes >> those references, as per the attached? > I think these can be safely removed. > In case they have an opinion on this, I've included Tom and Robert as > the authors of 629b3af2 and aecf5ee2. 629b3af2 just moved around the existing -I switch in adminpack/Makefile. AFAICS that switch goes back to adminpack's introduction, fe59e5666. It was probably just copied-and-pasted from some other contrib Makefile; since this Makefile has never actually linked libpq, it's hard to see why it'd be useful here. regards, tom lane
Commits
-
Remove references to libpq_srcdir in adminpack and old_snapshot
- 107a2d4204ff 14.0 landed