Horton

Re: Remove one TimestampTzGetDatum call in pg_stat_get_io()

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-09-06T14:38:18Z
Lists: pgsql-hackers 
Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
> While working on the per backend I/O statistics patch ([1]), I noticed that
> there is an unnecessary call to TimestampTzGetDatum() in pg_stat_get_io() (
> as the reset_time is already a Datum).

Hmm, TimestampTzGetDatum is not a no-op on 32-bit machines.  If you're
correct about this, why are our 32-bit BF animals not crashing?  Are
we failing to test this code?

			regards, tom lane

Commits

  1. Fix incorrect pg_stat_io output on 32-bit machines.