Horton

Re: Tests "with" and "alter_table" suffer from name clash

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-12-30T02:27:09Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@gmail.com> writes:
> With unlucky scheduling you can get a failure like this:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2021-12-22%2010%3A51%3A32
> Suggested fix attached.

Looks reasonable.  We really should avoid using such common
names for short-lived tables in any case --- it's an invitation
to trouble.  So I'd vote for changing the other use of "test", too.

			regards, tom lane

Commits

  1. Fix overly generic name in with.sql test.

  2. Clean up duplicate table and function names in regression tests.