Re: pg_dump/pg_dumpall help synopses and terminology

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Robert Treat <rob@xzilla.net>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-06-19T12:10:41Z
Lists: pgsql-hackers
On 18.06.25 22:57, Robert Treat wrote:
> I also wondered why you differentiated SQL script file vs archive in
> the change here:
> 
> -   of a cluster into an archive.  The archive contains
> +   of a cluster into an SQL script file or an archive.  The output contains
> 
> but then did not differentiate them here (I guess it should say SQL
> script files or archives?)
> 
>     <refpurpose>
> -   restore a <productname>PostgreSQL</productname> database or cluster
> -   from an archive created by <application>pg_dump</application> or
> +   restore <productname>PostgreSQL</productname> databases from archives
> +   created by <application>pg_dump</application> or
>      <application>pg_dumpall</application>
>     </refpurpose>

The second bit is from pg_restore, which does not restore SQL script 
files, only archives.

> I don't know if there is an official definition of an archive, but I
> don't tend to think of a single script (like default pg_dumpall) as an
> archive.

I agree.

> Granted, these are just minor tightening up at best; generally +1 to
> the clean up as a whole.

Committed.  Thanks for taking a look.




Commits

  1. Improve pg_dump/pg_dumpall help synopses and terminology

  2. doc: Avoid too prominent use of "backup" on pg_dump man page