Re: Proposal to improve uniq function documentation in intarray extension
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: martin.kalcher@aboutsource.net
Cc: pgsql-docs@lists.postgresql.org
Date: 2022-06-03T15:34:21Z
Lists: pgsql-docs
PG Doc comments form <noreply@postgresql.org> writes:
> The **uniq** function in the **intarray** extension removes **adjacent**
> duplicates from an integer array. The documentation[0] about this behavior
> is correct, but the example is a bit misleading, because it sorts the array
> before applying uniq. The sort can be overlooked **easily** and leads to the
> impression that **uniq** removes all duplicates from the array.
> I propse to change the example to somthing like that:
> uniq('{1,2,2,3,1,1}'::integer[]) → {1,2,3,1}
You have a point, but the example of use with sort() is pretty useful in
its own right, particularly for people for whom "blah blah | sort | uniq"
is not second nature. Fortunately, there's no longer any reason we have
to limit ourselves to one example. I propose this:
diff --git a/doc/src/sgml/intarray.sgml b/doc/src/sgml/intarray.sgml
index f930c08eeb..18c6f8c3ba 100644
--- a/doc/src/sgml/intarray.sgml
+++ b/doc/src/sgml/intarray.sgml
@@ -131,6 +131,11 @@
</para>
<para>
Removes adjacent duplicates.
+ Often used with <function>sort</function> to remove all duplicates.
+ </para>
+ <para>
+ <literal>uniq('{1,2,2,3,1,1}'::integer[])</literal>
+ <returnvalue>{1,2,3,1}</returnvalue>
</para>
<para>
<literal>uniq(sort('{1,2,3,2,1}'::integer[]))</literal>
regards, tom lane
Commits
-
Doc: improve example for intarray's uniq() function.
- 9985139046c3 13.8 landed
- c1ad8047a2c2 14.4 landed
- 4ecacc3c8cb4 15.0 landed