Horton

Re: [PATCH] nodeindexscan with reorder memory leak

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Aliaksandr Kalenik <akalenik@kontur.io>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-01-30T16:02:55Z
Lists: pgsql-hackers 
Aliaksandr Kalenik <akalenik@kontur.io> writes:
> The leak is only noticeable when index scan with reorder happens as part of
> subquery plan which is explained by the fact that heap tuples cloned in
> reorderqueue_push are not freed during flush of reorder queue in
> ExecReScanIndex.

Hmm ... I see from the code coverage report[1] that that part of
ExecReScanIndexScan isn't even reached by our existing regression
tests.  Seems bad :-(

			regards, tom lane

[1] https://coverage.postgresql.org/src/backend/executor/nodeIndexscan.c.gcov.html#577

Commits

  1. Fix memory leak in IndexScan node with reordering