Horton

Re: AIX support - alignment issues

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-07-06T14:01:00Z
Lists: pgsql-hackers 
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 06.07.22 04:21, Thomas Munro wrote:
>> /*
>> * Do not try to collapse these into one "w+" mode file. Doesn't work on
>> -	 * some platforms (eg, HPUX 10.20).
>> +	 * some platforms.
>> */
>> termin = fopen("/dev/tty", "r");
>> termout = fopen("/dev/tty", "w");

> I don't know how /dev/tty behaves in detail under stdio.  I think 
> removing this part of the comment might leave the impression that 
> attempting to use "w+" will never work, whereas the existing comment 
> appears to indicate that it was only very old platforms that had the 
> issue.  If we don't have an immediate answer to that, I'd leave the 
> comment as is.

Yeah, I was kind of wondering whether we should give w+ a try now.
IIRC, the code was like that at one point, but we had to change it
(ie the comment comes from bitter experience).  On the other hand,
it's probably not worth the trouble and risk to change it again.

			regards, tom lane

Commits

  1. Doc: Acknowledge historically supported CPUs and OSes.

  2. Further tidy-up for old CPU architectures.

  3. Tidy up claimed supported CPUs and OSes.

  4. Remove HP/Intel Itanium support.

  5. Remove HP-UX port.

  6. Reorder subskiplsn in pg_subscription to avoid alignment issues.

  7. Tighten TAP tests' tracking of postmaster state some more.

  8. Reorder pg_sequence columns to avoid alignment issue