Horton

Re: [PATCH] Fixed assertion issues in "pg_get_viewdef"

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: zengman <zengman@halodbtech.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-20T17:06:45Z
Lists: pgsql-hackers 
"=?gb18030?B?emVuZ21hbg==?=" <zengman@halodbtech.com> writes:
> Thanks for your guidance, you are right, I looked at your patch
> and combined it with the example to generate a new patch,
> which is really better.

I pushed the code fix, but I can't really convince myself that the
test case is worth the cycles it'd eat forevermore.  If we had
a way to reach the situation where there's setops but not any of
the other clauses in a leaf query, perhaps that would be worth
checking ... but we don't.  It's just belt-and-suspenders-too
programming.

			regards, tom lane

Commits

  1. Avoid assertion failure if a setop leaf query contains setops.