Horton

Re: A weird bit in pg_upgrade/exec.c

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: a.akenteva@postgrespro.ru, pgsql-hackers@postgresql.org
Date: 2017-11-09T16:21:26Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I think odd coding this was introduced recently because of the
> pg_resetxlog -> pg_resetwal renaming.

Dunno about that, but certainly somebody fat-fingered a refactoring
there.  The 9.6 code looks quite different but doesn't seem to be
doing anything silly.

			regards, tom lane

Commits

  1. Fix bogus logic for checking data dirs' versions within pg_upgrade.

  2. Fix bogus logic for checking executables' versions within pg_upgrade.