Re: BUG #17876: Function width_bucket() for float8 input returns value out of range
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mats Kindahl <mats@timescale.com>
Cc: pgsql-bugs@lists.postgresql.org
Date: 2023-04-05T21:41:06Z
Lists: pgsql-bugs
Mats Kindahl <mats@timescale.com> writes: > On Fri, Mar 31, 2023 at 3:14 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> While I'm not bothered too much if rounding affects which internal >> bucket a value lands in, it's a bit more annoying if that causes >> it to be reported as being in the end bucket, when we know positively >> that the value is less than bound2. Is it worth expending more >> cycles to prevent this? > I think it could be. I agree that it does not make sense to select the end > bucket when the value is in range, even if just. Yeah. I did that already at a2a0c7c29, sorry for not circling back to this thread. regards, tom lane
Commits
-
Further tweaking of width_bucket() edge cases.
- a2a0c7c29e47 16.0 landed
-
Avoid overflow in width_bucket_float8().
- b0e9e4d76ca2 16.0 landed