Re: patch for parallel pg_dump
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Joachim Wieland <joe@mcknight.de>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-02-07T16:39:14Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > most places that issue queries can simply use those routines without > needing to peek under the hood into the ArchiveHandle. This is not > quite enough to get rid of g_conn, but it's close: the major stumbling > block at this point is probably exit_nicely(). The gyrations we're > going through to make sure that AH->connection gets closed before > exiting are fairly annoying; maybe we should invent something in > dumputils.c along the line of the backend's on_shmem_exit(). Do we actually care about closing the connection? Worst case is that backend logs an "unexpected EOF" message. But yeah, an atexit hook might be the easiest solution. regards, tom lane