RE: Suggested change in include/utils/elog.h
Magnus Hagander <mha@sollentuna.net>
From: Magnus Hagander <mha@sollentuna.net>
To: "'Bruce Momjian'" <pgman@candle.pha.pa.us>, "David R. Favor" <dfavor@austin.ibm.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2000-09-30T08:28:53Z
Lists: pgsql-hackers
If you do decide to prefix DEBUG, please consider prefixing at least ERROR as well. It produces a lot of warnings when compiling on Win32 (ERROR is already defined as part of the standard windows headers). It's just warnings, though. //Magnus > Do other people have a comment on this. I am inclined to leave it > along. This is the first complaint I have heard, and > elog(PGDEBUG) just > looks funny. We don't prefix NOTICE or ERROR. > > > > In the file > > > > include/utils/elog.h > > > > there is a macro named > > > > DEBUG > > > > that conflicts with the perl5.6 macro DEBUG. > > > > PostgreSQL would probably "play" better with other products if > > the DEBUG macro had a prefix, maybe PGSQLDEBUG or similar. > > > > Until there is some fix in this area, plperl will not build with > > a version of perl that has debugging enabled. > > > > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 853-3000 > + If your life is a hard drive, | 830 Blythe Avenue > + Christ can be your backup. | Drexel Hill, > Pennsylvania 19026 >