Horton

Re: Disable OpenSSL compression

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Albe Laurenz <laurenz.albe@wien.gv.at>, "Christopher Browne *EXTERN*" <cbbrowne@gmail.com>, "ktm@rice.edu" <ktm@rice.edu>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2011-11-09T22:26:14Z
Lists: pgsql-hackers 
Magnus Hagander <magnus@hagander.net> writes:
> On Wednesday, November 9, 2011, Albe Laurenz wrote:
>> Is the following proposal acceptable:
>> 
>> - Add a GUC ssl_compression, defaulting to "on".
>> - Add a client option "sslcompression" and an environment variable
>> PGSSLCOMPRESSION, defaulting to "1".

> Seems like the reasonable thing, yes.

A GUC is entirely, completely, 100% the wrong answer.  It has no way to
deal with the fact that some clients may need compression and others
not.

It should be a client option, full stop.  The fact that that will be
more work to implement does not make "kluge it at the server" the right
answer.

			regards, tom lane