Horton

Re: pg_filenode_relation(0,0) elog

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-06-12T03:51:35Z
Lists: pgsql-hackers 
Justin Pryzby <pryzby@telsasoft.com> writes:
> Per sqlsmith.
> postgres=# SELECT pg_filenode_relation(0,0);
> ERROR:  unexpected duplicate for tablespace 0, relfilenode 0

Ugh.

> The usual expectation is that sql callable functions should return null rather
> than hitting elog().

Agreed, but you should put the short-circuit into the SQL-callable
function, ie pg_filenode_relation.  Lower-level callers ought not be
passing junk data.

Likely it should check the reltablespace, too.

			regards, tom lane

Commits

  1. Ensure pg_filenode_relation(0, 0) returns NULL.