Horton

Re: Introduce pg_receivewal gzip compression tests

gkokolatos@pm.me

View thread View on postgr.es
From: gkokolatos@pm.me
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-13T08:28:44Z
Lists: pgsql-hackers 

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Tuesday, July 13th, 2021 at 10:14, Michael Paquier <michael@paquier.xyz> wrote:

> On Tue, Jul 13, 2021 at 04:37:53PM +0900, Michael Paquier wrote:
>
> Poking at this problem, I partially take this statement back as this
> requires an initial run of pg_receivewal --endpos to ensure the
> creation of one .gz and one .gz.partial. So I guess that this should
> be structured as:
>
> 1.  Keep the existing pg_receivewal --endpos.
> 2.  Add the ZLIB block, with one pg_receivewal --endpos.
> 3.  Add at the end one extra pg_receivewal --endpos, outside of the ZLIB
>     block, which should check the creation of a .partial, non-compressed
>     segment. This should mention that we place this command at the end of
>     the test for the start streaming point computation.
>     LZ4 tests would be then between 2) and 3), or 1) and 2).

Sounds great. Let me cook up v6 for this.

>
>     --
>
>     Michael

Commits

  1. Re-enable TAP tests of pg_receivewal for ZLIB on Windows

  2. Fix some issues with WAL segment opening for pg_receivewal --compress

  3. Disable tests involving ZLIB on Windows for pg_receivewal

  4. Fix portability issue with gzip in TAP test of pg_receivewal

  5. Add TAP tests for ZLIB compression for pg_receivewal