Horton

Re: Wrong Results from SP-GiST with Collations

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Emre Hasegeli <emre@hasegeli.com>, Teodor Sigaev <teodor@sigaev.ru>, PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Date: 2018-04-16T19:28:54Z
Lists: pgsql-bugs 
Peter Geoghegan <pg@bowt.ie> writes:
> On Mon, Apr 16, 2018 at 11:51 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> and then the bit below about ...
>> needs to move into the "non-collation-aware" branch.

> Right. Alternatively, you could actually call varstr_cmp() within the
> "non-collation-aware" branch.

True.  This way saves a few cycles, but maybe it's not worth the extra
code.  I think the only case where you could really notice the difference
is for an equality search operator, which might end up doing a lot more
work in non-C collations (full-blown strcoll vs memcmp).

			regards, tom lane

Commits

  1. Fix broken collation-aware searches in SP-GiST text opclass.

  2. Add prefix operator for TEXT type.