Re: incompatible pointer types with newer zlib
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-02-24T16:10:16Z
Lists: pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes: > On tor, 2012-02-23 at 10:17 -0500, Tom Lane wrote: >> void * seems entirely reasonable given the two different usages, but >> I would be happier if the patch added explicit casts whereever FH is >> set to or used as one of these two types. > That would add about 70 casts all over the place. I don't think that > will make things clearer or more robust. I think we either leave it as > my first patch for now or find a more robust solution with a union or > something. Hm. Could we just create two separate fields? It's not real clear to me that forcing both these usages into a generic pointer buys much. regards, tom lane