Horton
Menu

Re: Adding REPACK [concurrently]

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Antonin Houska <ah@cybertec.at>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Mihail Nikalayeu <mihailnikalayeu@gmail.com>, Srinath Reddy Sadipiralla <srinath2133@gmail.com>, Matthias van de Meent <boekewurm+postgres@gmail.com>, Pg Hackers <pgsql-hackers@lists.postgresql.org>, Robert Treat <rob@xzilla.net>
Date: 2026-03-31T15:35:42Z
Lists: pgsql-hackers

Attachments

On 2026-Mar-31, Antonin Houska wrote:

> Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> > On Fri, Mar 27, 2026 at 10:31 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:

> > BTW, are we intending to commit this patch series for PG19?
> 
> Yes, that's the current plan.

Yes -- though as I said upthread, this particular patch in the series is
the one I'm the least sure about.  Also, the structure of the patches to
commit is not like the ones posted here or previously.  I'll post a
committable one later on; see below for a breakdown.  For now, I brought
the addition of options to table AM methods from [1] into this series,
in what I think is pretty much final form (0002); and I added a 0004
patch that's code review for the big patch, which I'll squash for the
next version, and is posted here separately just so that it's easy to
see.

My intention as to patches for final commit is:

- 0001 "Make index_concurrently_create_copy more general" same as here.
- 0002 "give options bitmask to table_delete/table_update" same as here,
       with a real commit message.
- 0003 Rename cluster.c/h to repack.c/h (similar to 0006 here); no
       essential change in contents.
- 0004 "Add CONCURRENTLY option to REPACK command".  Squash of 0003,
       0004, 0005 and 0007.
- 0005 "Error out any process that would block at REPACK", same as here.

I'm unsure on whether 0009 would be pushed or not.


[1] https://postgr.es/m/202603171606.kf6pmhscqbqz@alvherre.pgsql
 
-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Allow old WAL recycling during REPACK CONCURRENTLY

  2. Advance restart_lsn more eagerly in LogicalConfirmReceivedLocation

  3. Remove unnecessary signal handler change

  4. Improve REPACK (CONCURRENTLY) error messages some more

  5. Revert "Allow logical replication snapshots to be database-specific"

  6. Move REPACK (CONCURRENTLY) test out of stock regression tests

  7. REPACK: do not require REPLICATION or LOGIN

  8. Add missing initialization

  9. Simplify declaration of memcpy target

  10. Reserve replication slots specifically for REPACK

  11. doc: Add an example of REPACK (CONCURRENTLY)

  12. Allow logical replication snapshots to be database-specific

  13. Avoid different-size pointer-to-integer cast

  14. Fix valgrind failure

  15. Add CONCURRENTLY option to REPACK

  16. Rename cluster.c to repack.c (and corresponding .h)

  17. Allow index_create to suppress index_build progress reporting

  18. Make index_concurrently_create_copy more general

  19. Document the 'command' column of pg_stat_progress_repack

  20. Introduce the REPACK command

  21. Toggle logical decoding dynamically based on logical slot presence.

  22. Split vacuumdb to create vacuuming.c/h

  23. Remove ReorderBufferTupleBuf structure.

  24. Revert changes to CONCURRENTLY that "sped up" Xmin advance

  25. VACUUM: ignore indexing operations with CONCURRENTLY