Horton
Menu

Re: Row pattern recognition

Tatsuo Ishii <ishii@postgresql.org>

View thread
From: Tatsuo Ishii <ishii@postgresql.org>
To: assam258@gmail.com
Cc: zsolt.parragi@percona.com, vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com, david.g.johnston@gmail.com, peter@eisentraut.org, pgsql-hackers@postgresql.org
Date: 2026-03-12T00:21:25Z
Lists: pgsql-hackers 
Hi Zsolt,

Thanks for the report and the test case!

> Good catch, Zsolt. You're right ― the return value of
> coerce_to_boolean() must be assigned back to te->expr, otherwise
> any implicit cast (e.g., a user-defined type with an assignment
> cast to boolean) is silently discarded.
> 
> The fix is straightforward:
> 
>     foreach_ptr(TargetEntry, te, defineClause)
>         te->expr = (Expr *) coerce_to_boolean(pstate, (Node *) te->expr,
> "DEFINE");
> 
> I've confirmed that your example query produces incorrect results
> without the fix (the truthyint value is evaluated as-is without
> the cast) and correct results with it.
> 
> Patch 13 is attached with the fix and a regression test case based
> on your example.

Yeah, current patch needs to be fixed. Question is, the output of the
expression of DEFINE clause must be a strict boolean or, it is allowed
to accept an expression coercive to boolean?

If we prefer the former, we should use exprType() instead.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust cross-version upgrade tests for seg_out() fix

  2. Rationalize error comments in partition split/merge tests

  3. Add fast path for foreign key constraint checks

  4. Fix assorted pretty-trivial memory leaks in the backend.

  5. Add temporal FOREIGN KEY contraints

  6. Add trailing commas to enum definitions

  7. Remove obsolete executor cleanup code