Horton
Menu

Re: Fix array access (src/bin/pg_dump/pg_dump.c)

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2026-03-07T13:33:08Z
Lists: pgsql-hackers 
On 2024-Nov-12, Ranier Vilela wrote:

> Em ter., 12 de nov. de 2024 às 16:11, Alvaro Herrera <
> alvherre@alvh.no-ip.org> escreveu:
> 
> > On 2024-Nov-12, Ranier Vilela wrote:
> >
> > > Per Coverity.
> > >
> > > The function *determineNotNullFlags* has a little oversight.
> > > The struct field *notnull_islocal* is an array.
> > >
> > > I think this is a simple typo.
> > > Fix using array notation access.
> >
> > Yeah, thanks, I had been made aware of this bug.  Before fixing I'd like
> > to construct a test case that tickles that code, because it's currently
> > uncovered  *shudder*
>
> Thanks for taking care of this.

Fixed, thanks.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix invalid boolean if-test