Horton
Menu

Re: Row pattern recognition

Tatsuo Ishii <ishii@postgresql.org>

View thread
From: Tatsuo Ishii <ishii@postgresql.org>
To: assam258@gmail.com
Cc: vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com, david.g.johnston@gmail.com, peter@eisentraut.org, pgsql-hackers@postgresql.org
Date: 2026-02-24T05:09:27Z
Lists: pgsql-hackers 
Hi Henson,

>> BTW, in create_windowagg_plan (createplan.c),
>> around:
>> /* Build RPR pattern and filter defineClause */
>>
>> collectPatternVariables, filterDefineClause and buildRPRPattern are
>> called in a block without any if or any other conditional
>> statements. This is an unusual codiing style in PostgreSQL.  I suggest
>> to fix this.  Attached is a proposed patch for this.
> 
> Good catch, thank you!  I've renumbered your patch as nocfbot-0007
> and extended the same cleanup to rpr.c and parse_rpr.c as
> nocfbot-0008.
> 
> nocfbot-0007: Refactor create_windowagg_plan to remove bare
>               variable-scoping block (your patch, renumbered)
> 
> nocfbot-0008: Remove bare variable-scoping blocks in RPR code
> 
>   Applies the same cleanup to rpr.c and parse_rpr.c, with minor
>   pgindent formatting fixes.
> 
> I'll keep this coding style point in mind for future code as well.

Thank you for quick response!

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust cross-version upgrade tests for seg_out() fix

  2. Rationalize error comments in partition split/merge tests

  3. Add fast path for foreign key constraint checks

  4. Fix assorted pretty-trivial memory leaks in the backend.

  5. Add temporal FOREIGN KEY contraints

  6. Add trailing commas to enum definitions

  7. Remove obsolete executor cleanup code