Re: pgstat include expansion

Álvaro Herrera <alvherre@kurilemu.de>

View thread View on postgr.es

From: Alvaro Herrera <alvherre@kurilemu.de>

To: Andres Freund <andres@anarazel.de>

Cc: pgsql-hackers@postgresql.org, Amit Kapila <amit.kapila16@gmail.com>, Michael Paquier <michael@paquier.xyz>

Date: 2026-02-16T16:19:51Z

Lists: pgsql-hackers

Attachments

0002-remove-inclusions-in-pgstat.h.patch (text/x-diff)

On 2026-Feb-16, Alvaro Herrera wrote:

> I think we should in addition remove some includes that were kept during
> recent IWYU hacking "for backwards compatibility", and instead include
> them explicitly wherever they are needed.  The attached does that.

Sigh, I forgot the attachments.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Commits

Don't include wait_event.h in pgstat.h
- 868825aaeb40 19 (unreleased) landed
Don't include proc.h in shm_mq.h
- a2c89835f512 19 (unreleased) landed
Don't include latch.h in libpq/libpq.h
- 7b9b620d8fc7 19 (unreleased) landed
Reduce includes in pgstat.h
- 7bb50dd7d6b9 19 (unreleased) landed
Avoid including utils/timestamp.h in conflict.h.
- 308622edf174 19 (unreleased) landed
Avoid including worker_internal.h in pgstat.h.
- 9842e8aca096 19 (unreleased) landed
Add seq_sync_error_count to subscription statistics.
- f6a4c498dcf6 19 (unreleased) cited
Don't include execnodes.h in replication/conflict.h
- 7e638d7f5093 19 (unreleased) cited
Collect statistics about conflicts in logical replication.
- 6c2b5edecc0d 18.0 cited