Re: Row pattern recognition

Hi Henson,

>  Attached is the patch with the following changes:
[snip]

After applying your patch on top of v39 patch sets, I see compiler
warnings:

nodeWindowAgg.c: In function ‘nfa_absorb_contexts’:
nodeWindowAgg.c:5565:47: warning: the comparison will always evaluate as ‘true’ for the address of ‘counts’ will never be NULL [-Waddress]
 5565 |                                 if (s->counts != NULL && s->counts[0] > newerMaxCount)
      |                                               ^~
In file included from ../../../src/include/executor/execdesc.h:18,
                 from ../../../src/include/executor/executor.h:18,
                 from nodeWindowAgg.c:41:
../../../src/include/nodes/execnodes.h:2532:25: note: ‘counts’ declared here
 2532 |         int32           counts[FLEXIBLE_ARRAY_MEMBER];  /* repetition counts by depth */
      |                         ^~~~~~
nodeWindowAgg.c:5572:47: warning: the comparison will always evaluate as ‘true’ for the address of ‘counts’ will never be NULL [-Waddress]
 5572 |                                 if (s->counts != NULL && s->counts[0] > olderMaxCount)
      |                                               ^~
../../../src/include/nodes/execnodes.h:2532:25: note: ‘counts’ declared here
 2532 |         int32           counts[FLEXIBLE_ARRAY_MEMBER];  /* repetition counts by depth */
      |                         ^~~~~~
nodeWindowAgg.c:5429:33: warning: variable ‘maxDepth’ set but not used [-Wunused-but-set-variable]
 5429 |         int                     maxDepth;
      |                                 ^~~~~~~~

Shall I fix them (and post v40 patches), or would you like to fix and
post another patch?

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp