Re: remove the unneeded header file math.h in binaryheap.c
Álvaro Herrera <alvherre@kurilemu.de>
From: Álvaro Herrera <alvherre@kurilemu.de>
To: liujinyang <21043272@qq.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-13T17:18:19Z
Lists: pgsql-hackers
On 2026-Jan-13, liujinyang wrote: > Hi Hackers, > > I found in file binaryheap.c, file "math.h" was included, but it is uncessary, so I removed it > and filing a patch to address the issue. Fun. This was already unnecessary at commit 7a2fe9bd0371 which introduced the file. It seems Abhijit had that include in his first version [1] because he was using floor(). Robert rewrote it later [2] and replaced that with straight arithmetic, making the include unnecessary, but forgot to remove it. [1] https://postgr.es/m/20121114131112.GA27771@toroid.org [2] https://postgr.es/m/CA%2BTgmobvR7XW9fjj2RNY7sKK-VAG5nahfai_zV51rHVLDNvaBg%40mail.gmail.com -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Commits
-
Remove #include <math.h> where not needed
- 35e3fae738e6 19 (unreleased) landed
-
Remove unnecessary uses of Abs()
- f14aad5169ba 16.0 cited
-
Basic binary heap implementation.
- 7a2fe9bd0371 9.3.0 cited