Horton
Menu

Re: [PATCH] Expose checkpoint reason to completion log messages.

Michael Banck <mbanck@gmx.net>

View thread
From: Michael Banck <mbanck@gmx.net>
To: Soumya S Murali <soumyamurali.work@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, VASUKI M <vasukianand0119@gmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Álvaro Herrera <alvherre@kurilemu.de>, melanieplageman@gmail.com, juanjo.santamaria@gmail.com
Date: 2026-01-07T08:07:18Z
Lists: pgsql-hackers 
Hi,

On Wed, Jan 07, 2026 at 12:35:08PM +0530, Soumya S Murali wrote:
> I agree with your point that the checkpoint completion message should
> use the same terminology as the starting message ( “fast” rather than
> “immediate”) and I have updated the patch accordingly and have
> attached herewith for review. This patch aligns the checkpoint
> completion log wording with the existing checkpoint starting message
> (using “fast” instead of “immediate”) for consistency.

First off, please send complete and not incremental patches.

From what I can tell, you currently also do not have "wal" as reason?
Also, you have "timed" vs "time" etc.

I think it would make most sense to factor out the logic for the
starting checkpoint reason from xlog.c ("(errmsg("checkpoint 
starting:%s%s%s%s%s%s%s%s")") and use that both for starting and
stopping.


Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Log checkpoint request flags in checkpoint completion messages.