Horton

Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

Tatsuo Ishii <ishii@postgresql.org>

View thread View on postgr.es
From: Tatsuo Ishii <ishii@postgresql.org>
To: masao.fujii@gmail.com
Cc: li.evan.chao@gmail.com, jian.universality@gmail.com, pgsql-hackers@postgresql.org
Date: 2026-06-18T08:27:47Z
Lists: pgsql-hackers 
> I've updated the patch accordingly.
> 
> I removed "is" from "RESPECT/IGNORE NULLS is specified" to match other
> similar error messages, which use the form "XXX specified, ...".
> 
> + if (ignore_nulls != NO_NULLTREATMENT)
> + ereport(ERROR,
> + (errcode(ERRCODE_WRONG_OBJECT_TYPE),

The errcode field can start without a parenthesis:

errcode(ERRCODE_WRONG_OBJECT_TYPE),

Other than that the patch looks good to me.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Commits

  1. Remove stray blank line in ParseFuncOrColumn()

  2. Refine error reporting for null treatment on non-window functions

  3. Fix error message typo.

  4. Fix to not allow null treatment to non window functions.

  5. Add IGNORE NULLS/RESPECT NULLS option to Window functions.