Horton

Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

Tatsuo Ishii <ishii@postgresql.org>

View thread View on postgr.es
From: Tatsuo Ishii <ishii@postgresql.org>
To: li.evan.chao@gmail.com
Cc: jian.universality@gmail.com, pgsql-hackers@postgresql.org
Date: 2026-06-17T03:58:05Z
Lists: pgsql-hackers 
Hi Chao,

> Hi Tatsuo-san,
> 
> Sorry for jumping in. I didn’t review the patch, but while browsing recent commits, I noticed that this commit has a small issue: the errmsg should start with a lowercase character, according to the error style guide [1]:
> ```
> Primary error messages: Do not capitalize the first letter. Do not end a message with a period. Do not even think about ending a message with an exclamation point.
> ```
> 
> The attached diff is a quick fix that changes “Only” to “only” and updates the expected output accordingly.
> 
> [1] https://www.postgresql.org/docs/current/error-style-guide.html

You are right. I don't know why I forgot the rule. Patch pushed.
Thank you!
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Commits

  1. Remove stray blank line in ParseFuncOrColumn()

  2. Refine error reporting for null treatment on non-window functions

  3. Fix error message typo.

  4. Fix to not allow null treatment to non window functions.

  5. Add IGNORE NULLS/RESPECT NULLS option to Window functions.