Horton

Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

Tatsuo Ishii <ishii@postgresql.org>

View thread View on postgr.es
From: Tatsuo Ishii <ishii@postgresql.org>
To: jian.universality@gmail.com
Cc: pgsql-hackers@postgresql.org
Date: 2026-06-17T01:17:14Z
Lists: pgsql-hackers 
>> > To fix this, ParseFuncOrColumn() now checks whether other than window
>> > functions are used with the null treatment clause. If so, error out.
>> >
>> > Also remove the unnecessary test for "aggregate functions do not
>> > accept RESPECT/IGNORE NULLS" because it is now checked in the
>> > early-stage new check. The window regression test expected file is
>> > changed accordingly.
>>
>> I'm going to push the patch today if there's no objection.
> 
> The code looks good to me, and the commit message is clear and well-written.

Thank you for the review!
I have pushed the patch to master branch.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4e5920e6de87dc1ed761d2a898b7786c50c11db2
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Commits

  1. Remove stray blank line in ParseFuncOrColumn()

  2. Refine error reporting for null treatment on non-window functions

  3. Fix error message typo.

  4. Fix to not allow null treatment to non window functions.

  5. Add IGNORE NULLS/RESPECT NULLS option to Window functions.