Re: some more include removal from headers
Álvaro Herrera <alvherre@kurilemu.de>
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-02T22:14:51Z
Lists: pgsql-hackers
Attachments
- 0001-don-t-include-bufmgr.h-in-nbtree.h.patch (text/x-diff)
Hello, On 2026-Apr-02, Andres Freund wrote: > On 2026-04-02 20:24:29 +0200, Álvaro Herrera wrote: > > Looking at what else includes bufmgr.h, I think the minimum it can > > reduced to is compiling 157 files when you change bufmgr.h, per the > > patches attached here. Most of them are direct inclusions, so reducing > > further is tough. The only one we could blame is xlogutils.h, but it > > needs the ReadBufferMode enum, so in order to do better, we'd have to > > split bufmgr.h in two. > > I think you may have forgotten to attach the changes? Hm, so I did. Here they are. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Las mujeres son como hondas: mientras más resistencia tienen, más lejos puedes llegar con ellas" (Jonas Nightingale, Leap of Faith)
Commits
-
Reduce header inclusions via execnodes.h
- fba4233c8328 19 (unreleased) landed