Horton

Re: pg_dump crash due to incomplete ordering of DO_SUBSCRIPTION_REL objects

Noah Misch <noah@leadboat.com>

View thread
From: Noah Misch <noah@leadboat.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-18T21:10:02Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs.

  2. Sort dump objects independent of OIDs, for the 7 holdout object types.

On Thu, Dec 18, 2025 at 05:35:45PM +0530, vignesh C wrote:
> On Thu, 18 Dec 2025 at 14:05, Chao Li <li.evan.chao@gmail.com> wrote:
> > > On Dec 18, 2025, at 03:51, Noah Misch <noah@leadboat.com> wrote:
> > > I plan to push the attached version.
> > > <DO_SUBSCRIPTION_REL-v4.patch>

Pushed as d49936f etc.

> > 2
> > ```
> > +               /* Sort by subscription name, since (namespace, name) match the rel */
> > ```
> >
> > This comment is correct, but sounds a little insider-ish. Maybe:
> >
> > /* Tiebreak by subscription name; (namespace, name) already identify the table */
> 
> Similarly here too, it is inline with similar comments of other enums
> in this function.

Exactly.  For cosmetics, consistency with nearby code is the stronger rule.