Horton
Menu

Re: Cleanup shadows variable warnings, round 1

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-04T11:21:15Z
Lists: pgsql-hackers 
On 2025-Dec-04, Chao Li wrote:

> The motivation is that CF’s CI currently fails on shadow-variable warnings.
> If you touch a file like a.c, and that file already has a legacy shadowing
> issue, CI will still fail your patch even if your changes are correct. Then
> you’re forced to fix unrelated shadow-variable problems just to get a clean
> CI run. I’ve run into this myself, and it’s disruptive for both patch
> authors and reviewers.

Hmm, maybe that should be turned off.  It sounds seriously unhelpful.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"En las profundidades de nuestro inconsciente hay una obsesiva necesidad
de un universo lógico y coherente. Pero el universo real se halla siempre
un paso más allá de la lógica" (Irulan)

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix new-to-v19 -Wshadow warnings

  2. Reduce scope of for-loop-local variables to avoid shadowing

  3. Fix local-variable shadowing in pg_trgm's printSourceNFA().