Horton

Re: pg_createsubscriber --dry-run logging concerns

Álvaro Herrera <alvherre@kurilemu.de>

View thread View on postgr.es
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, Euler Taveira <euler@eulerto.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-18T15:39:05Z
Lists: pgsql-hackers 
On 2025-Nov-12, Peter Smith wrote:

> It is tempting to implement a "--silent" mode, but if I did that, I
> would then feel obliged to document and test it. I don't want to go
> further down this rabbit hole for what was originally supposed to be
> trivial logging.

Yeah, I understand.

> So, I am calling it quits for this 0001 patch.
> 
> Perhaps it's still of some use to push changes for everything except
> the pg_resetwal? Or if you prefer to just abandon the whole patch,
> that is OK too. Thanks for trying.

Got it.  I pushed it for the other programs and marked the CF entry as
committed -- thanks for the patches and the discussion.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"I'm impressed how quickly you are fixing this obscure issue. I came from 
MS SQL and it would be hard for me to put into words how much of a better job
you all are doing on [PostgreSQL]."
 Steve Midgley, http://archives.postgresql.org/pgsql-sql/2008-08/msg00000.php

Commits

  1. Split dry-run messages into primary and detail

  2. Log a note at program start when running in dry-run mode

  3. Use USECS_PER_SEC from datatype/timestamp.h

  4. Remove WaitPMResult enum in pg_createsubscriber

  5. pg_createsubscriber: reword dry-run log messages